Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: consolidate redundant require() calls #21699

Merged
merged 1 commit into from
Jul 10, 2018
Merged

lib: consolidate redundant require() calls #21699

merged 1 commit into from
Jul 10, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/219/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jul 7, 2018
@Trott
Copy link
Member

Trott commented Jul 7, 2018

Another spurious linter error that only seems to show up in auto-started linter jobs.

@cjihrig
lib: consolidate redundant require() calls
573744c 
PR-URL: nodejs#21699
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 10, 2018

CI with one flake that failed: https://ci.nodejs.org/job/node-test-pull-request/15776/

@cjihrig cjihrig merged commit 573744c into nodejs:master Jul 10, 2018
@cjihrig cjihrig deleted the no-dup-reqs branch July 10, 2018 02:52
targos pushed a commit that referenced this pull request Jul 10, 2018
@cjihrig @targos
lib: consolidate redundant require() calls
92d7921 
PR-URL: #21699
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@maclover7 maclover7 maclover7 approved these changes

@JungMinu JungMinu JungMinu approved these changes

@devsnek devsnek devsnek approved these changes

@fosslinux fosslinux fosslinux approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @Trott @targos @maclover7 @JungMinu @devsnek @fosslinux